Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Handle all let underscore instances #8898

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

cloneable
Copy link
Contributor

  • Most can be simply replaced
  • One instance renamed to _rtchk (return-type check)

Problem

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

* Most can be simply replaced
* One instance renamed to _rtchk (return-type check)
@cloneable cloneable requested a review from a team as a code owner September 3, 2024 15:02
Copy link

github-actions bot commented Sep 3, 2024

3815 tests run: 3709 passed, 0 failed, 106 skipped (full report)


Flaky tests (1)

Postgres 16

Code coverage* (full report)

  • functions: 32.4% (7416 of 22879 functions)
  • lines: 50.5% (60027 of 118795 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
939c911 at 2024-09-03T15:54:19.321Z :recycle:

@cloneable cloneable merged commit bae793f into main Sep 10, 2024
69 checks passed
@cloneable cloneable deleted the cloneable/proxy-let-underscore-check branch September 10, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants