Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage-controller): add node shards api #8896

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Sep 2, 2024

Problem

For control-plane managed tenants, we have the page in the admin console that lists all tenants on a specific pageserver. But for storage-controller managed ones, we don't have that functionality for now.

Summary of changes

Adds an API that lists all shards on a given node (intention + observed)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
Copy link

github-actions bot commented Sep 2, 2024

3843 tests run: 3729 passed, 0 failed, 114 skipped (full report)


Flaky tests (5)

Postgres 16

Postgres 14

Code coverage* (full report)

  • functions: 31.8% (7342 of 23065 functions)
  • lines: 50.0% (59474 of 118977 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9d191a5 at 2024-09-06T16:42:45.506Z :recycle:

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh marked this pull request as ready for review September 3, 2024 20:53
@skyzh skyzh requested a review from a team as a code owner September 3, 2024 20:53
@skyzh skyzh requested review from arpad-m and jcsp September 3, 2024 20:53
Signed-off-by: Alex Chi Z <chi@neon.tech>
arpad-m
arpad-m previously requested changes Sep 3, 2024
control_plane/storcon_cli/src/main.rs Outdated Show resolved Hide resolved
test_runner/fixtures/common_types.py Outdated Show resolved Hide resolved
control_plane/storcon_cli/src/main.rs Outdated Show resolved Hide resolved
@jcsp
Copy link
Collaborator

jcsp commented Sep 4, 2024

Please fill out the PR template: the "Problem" part is important too as it tells us why this change is needed.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh changed the title feat(storage-controller): add node attached api feat(storage-controller): add node shards api Sep 5, 2024
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested review from jcsp and arpad-m September 5, 2024 20:10
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh
Copy link
Member Author

skyzh commented Sep 5, 2024

Now the API is called node_shards, and returns both observed + intended states.

@skyzh skyzh dismissed arpad-m’s stale review September 6, 2024 18:13

resolved the comments

@skyzh skyzh merged commit ac5815b into main Sep 6, 2024
67 checks passed
@skyzh skyzh deleted the skyzh/node-attached branch September 6, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants