Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: bump parquet #7782

Merged
merged 2 commits into from
May 19, 2024
Merged

proxy: bump parquet #7782

merged 2 commits into from
May 19, 2024

Conversation

conradludgate
Copy link
Contributor

Summary of changes

Updates the parquet lib. one change left that we need is in an open PR against upstream, hopefully we can remove the git dependency by 52.0.0 apache/arrow-rs#5773

I'm not sure why the parquet files got a little bit bigger. I tested them and they still open fine. 🤷

side effect of the update, chrono updated and added yet another deprecation warning (hence why the safekeepers change)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested review from a team as code owners May 16, 2024 11:41
Copy link

github-actions bot commented May 16, 2024

3078 tests run: 2951 passed, 0 failed, 127 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_pageserver_init_node_id: release

Code coverage* (full report)

  • functions: 31.3% (6382 of 20401 functions)
  • lines: 47.7% (48636 of 101902 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
512c984 at 2024-05-19T19:53:30.063Z :recycle:

@conradludgate conradludgate enabled auto-merge (squash) May 19, 2024 19:06
@conradludgate conradludgate merged commit a5ecca9 into main May 19, 2024
44 checks passed
@conradludgate conradludgate deleted the bump-parquet branch May 19, 2024 19:45
a-masterov pushed a commit that referenced this pull request May 20, 2024
## Summary of changes

Updates the parquet lib. one change left that we need is in an open PR
against upstream, hopefully we can remove the git dependency by 52.0.0
apache/arrow-rs#5773

I'm not sure why the parquet files got a little bit bigger. I tested
them and they still open fine. 🤷

side effect of the update, chrono updated and added yet another
deprecation warning (hence why the safekeepers change)
hlinnaka added a commit that referenced this pull request Sep 7, 2024
PR #7782 set the dependency in Cargo.toml to 'master', and locked the
version to commit that contained a specific fix, because we needed the
fix before it was included in a versioned release. The fix was later
included in parquet crate version 52.0.0, so we can now switch back to
using a released version. The latest release is 53.0.0, switch
straight to that.
hlinnaka added a commit that referenced this pull request Sep 9, 2024
PR #7782 set the dependency in Cargo.toml to 'master', and locked the
version to commit that contained a specific fix, because we needed the
fix before it was included in a versioned release. The fix was later
included in parquet crate version 52.0.0, so we can now switch back to
using a released version. The latest release is 53.0.0, switch straight
to that.

---------

Co-authored-by: Conrad Ludgate <conradludgate@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants