Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry to fetching basebackup #6537

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Add retry to fetching basebackup #6537

merged 3 commits into from
Feb 1, 2024

Conversation

save-buffer
Copy link
Contributor

Problem

Currently we have no retry mechanism for fetching basebackup. If there's an unstable connection, starting compute will just fail.

Summary of changes

Adds an exponential backoff with 5 retries to get the basebackup.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@save-buffer save-buffer requested review from a team as code owners January 30, 2024 23:32
@save-buffer save-buffer requested review from mattpodraza, knizhnik and jcsp and removed request for a team January 30, 2024 23:32
Copy link

github-actions bot commented Jan 31, 2024

2376 tests run: 2261 passed, 0 failed, 115 skipped (full report)


Flaky tests (5)

Postgres 16

  • test_statvfs_pressure_min_avail_bytes: debug

Postgres 15

  • test_statvfs_pressure_usage: debug
  • test_gc_cutoff: debug
  • test_timeline_size_quota_on_startup: release

Postgres 14

  • test_statvfs_pressure_usage: debug

Code coverage (full report)

  • functions: 54.5% (11224 of 20610 functions)
  • lines: 81.5% (63253 of 77648 lines)

The comment gets automatically updated with the latest test results
749d6a8 at 2024-02-01T21:00:49.490Z :recycle:

compute_tools/src/compute.rs Outdated Show resolved Hide resolved
@save-buffer save-buffer merged commit be30388 into main Feb 1, 2024
46 checks passed
@save-buffer save-buffer deleted the sasha_retry_basebackup branch February 1, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants