-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent unintentional Postgres submodule update #4692
Conversation
72fa961
to
1f9ccc8
Compare
before: `Timed out while waiting for WAL record at LSN ... to arrive, last_record_lsn ... disk consistent LSN=..., WalReceiver status: WalReceiver status: disconnected` after: `Timed out while waiting for WAL record at LSN ... to arrive, last_record_lsn ... disk consistent LSN=..., WalReceiver status: disconnected`
1f9ccc8
to
f52daf1
Compare
f52daf1
to
0b8f032
Compare
1028 tests run: 976 passed, 0 failed, 52 skipped (full report) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's test this still with wrong commits but I can't see why it wouldn't work. You beat me to it :) Maybe add just revert 9169c99 so others will see this was tested...?
Here's an example of failed step:
|
91bec0d
to
8a3968f
Compare
Problem
Postgres submodule can be changed unintentionally, and these changes are easy to miss during the review.
Adding a check that should prevent this from happening, the check fails
build-neon
job with the following message:This is an alternative approach to #4603
Summary of changes
vendor/revisions.json
file with expected revisionsbuild-neon
job) that Postgres submodules match revisions fromvendor/revisions.json
Checklist before requesting a review
Checklist before merging