[compute_ctl] Empty computes and /configure API #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ololobus
force-pushed
the
alexk/empty-compute
branch
from
594ce5b
to
1427996
Compare
Test results for cf745b6:debug build: 212 tests run: 202 passed, 0 failed, 10 (full report)release build: 212 tests run: 202 passed, 0 failed, 10 (full report) |
lubennikovaav
approved these changes
Apr 6, 2023
8 tasks
ololobus
force-pushed
the
alexk/empty-compute
branch
2 times, most recently
from
254edd4
to
d2585b9
Compare
This commit adds an option to start compute without spec and then pass
it a valid spec via `POST /configure` API endpoint. This is a main
prerequisite for maintaining the pool of compute nodes in the
control-plane.
For example:
1. Start compute with
```shell
cargo run --bin compute_ctl -- -i no-compute \
-p http://localhost:9095 \
-D compute_pgdata \
-C "postgresql://cloud_admin@127.0.0.1:5434/postgres" \
-b ./pg_install/v15/bin/postgres
```
2. Configure it with
```shell
curl -d "{\"spec\": $(cat ./compute-spec.json)}" http://localhost:3080/configure
```
Internally, it's implemented using a `Condvar` + `Mutex`. Compute spec
is moved under Mutex, as it's now could be updated in the http handler.
Also `RwLock` was replaced with `Mutex` because the latter works well
with `Condvar`.
First part of the neondatabase/cloud#4433
ololobus
force-pushed
the
alexk/empty-compute
branch
from
d2585b9
to
cf745b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This commit adds an option to start compute without spec and then pass it a valid spec via
POST /configureAPI endpoint. This is a main prerequisite for maintaining the pool of compute nodes in the control-plane.For example:
Start compute with
-p http://localhost:9095 \ -D compute_pgdata \ -C "postgresql://cloud_admin@127.0.0.1:5434/postgres" \ -b ./pg_install/v15/bin/postgresConfigure it with
shell curl -d "{\"spec\": $(cat ./compute-spec.json)}" http://localhost:3080/configureInternally, it's implemented using a
Condvar+Mutex. Compute spec is moved under Mutex, as it's now could be updated in the http handler. AlsoRwLockwas replaced withMutexbecause the latter works well withCondvar.First part of the #3923
Issue ticket number and link
First part of https://github.com/neondatabase/cloud/issues/4433
Checklist before requesting a review
Checklist before merging