-
Notifications
You must be signed in to change notification settings - Fork 729
Use :local compute-tools tag to build compute-node image #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Do we even need to push compute-tools
to the dockerhub?
I don't know, previously I used it from time to time if I needed to build compute-node locally, but didn't want to rebuild everything. Sounds like a very rare case, though. Yet, it shouldn't hurt is we push a couple more images |
876cebf
to
7a38da2
Compare
7a38da2
to
434a713
Compare
Postgres PR neondatabase/postgres#170
Cloud PR https://github.com/neondatabase/cloud/pull/1446