Skip to content

Commit

Permalink
Lsn for get_timestamp_of_lsn should be string, not integer (#5840)
Browse files Browse the repository at this point in the history 
The `get_timestamp_of_lsn` pageserver endpoint has been added in #5497,
but the yml it added was wrong: the lsn is expected in hex format, not
in integer (decimal) format.
  • Loading branch information
@arpad-m
arpad-m authored Nov 9, 2023
1 parent e0821e1 commit f95f001
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pageserver/src/http/openapi_spec.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,8 @@ paths:
in: query
required: true
schema:
type: integer
type: string
format: hex
description: A LSN to get the timestamp
responses:
"200":
Expand Down

1 comment on commit f95f001

@github-actions
Copy link

@github-actions github-actions bot commented on f95f001 Nov 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2444 tests run: 2320 passed, 0 failed, 124 skipped (full report)

Flaky tests (5)

Postgres 14

  • test_competing_branchings_from_loading_race_to_ok_or_err: release
  • test_crafted_wal_end[last_wal_record_xlog_switch_ends_on_page_boundary]: release
  • test_ondemand_download_timetravel[local_fs]: release
  • test_emergency_mode: release
  • test_empty_tenant_size: release

Code coverage (full report)

  • functions: 54.5% (8913 of 16363 functions)
  • lines: 81.5% (51334 of 62985 lines)
The comment gets automatically updated with the latest test results
f95f001 at 2023-11-09T20:40:35.657Z :recycle:

Please sign in to comment.