Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Unit tests for the function filter_with_lists #191

Merged
merged 7 commits into from
Aug 24, 2023

Conversation

xffxff
Copy link
Contributor

@xffxff xffxff commented Aug 24, 2023

What does this PR do?

This PR adds the documentation and tests for the function filter_with_lists. Also, this PR adds progress on the issue #179.

Why is this change important?

This change is essential as this provides the developer with the ability to test the function more extensively.

How to test this PR locally?

It can be tested by cloning the repository and running cargo test command.

git clone https://github.com/neon-mmd/websurfx
cd websurfx
cargo test

Author's checklist

  • add docs for filter_with_lists
  • some unit tests for filter_with_lists
  • bump the app version to v0.18.1

Related issues

#179

@xffxff xffxff requested review from neon-mmd and alamin655 August 24, 2023 01:49
@neon-mmd neon-mmd changed the title add some unit tests for the function filter_with_lists 🧹 Unit tests for the function filter_with_lists Aug 24, 2023
@neon-mmd neon-mmd added this to the Finish v1.0.0 milestone Aug 24, 2023
@xffxff xffxff requested a review from neon-mmd August 24, 2023 09:12
Copy link
Owner

@neon-mmd neon-mmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️ once again for working on this. Since everything looks good, I will merge this PR right away.

@neon-mmd neon-mmd merged commit 7a8bf02 into neon-mmd:rolling Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants