Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix race condition on shutdown #913

Merged
merged 2 commits into from
Jul 6, 2022
Merged

fix: Fix race condition on shutdown #913

merged 2 commits into from
Jul 6, 2022

Conversation

kjvalencik
Copy link
Member

No description provided.

dherman
dherman approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a couple small suggestions for the comments.

crates/neon/src/sys/no_panic.rs Show resolved Hide resolved
test/napi/lib/workers.js Show resolved Hide resolved
@kjvalencik kjvalencik merged commit bceacdd into main Jul 6, 2022
@kjvalencik kjvalencik deleted the kv/shutdown-race branch July 6, 2022 19:48
@srriddle srriddle mentioned this pull request Jul 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman dherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjvalencik @dherman