-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typed Array discoverability #909
Commits on Jul 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e5ee685 - Browse repository at this point
Copy the full SHA e5ee685View commit details -
- Use aquamarine crate to product the type hierarchy diagram in neon:…
…:types API docs - Delete the PowerPoint-generated digram - Refactor the module tree slightly, in order to wrap the module docs with `#[aquamarine]` attribute - Flesh out the remaining blank spots in the typed array API docs - Change the `Binary` trait to use an associated constant instead of a nullary method
Configuration menu - View commit details
-
Copy full SHA for 6d136af - Browse repository at this point
Copy the full SHA 6d136afView commit details -
- change from top-to-bottom to left-to-right - make rectangles rounded
Configuration menu - View commit details
-
Copy full SHA for a50522e - Browse repository at this point
Copy the full SHA a50522eView commit details -
- Divide type hierarchy diagram into two diagrams and add some more c…
…opy around them - Turn every node in the diagrams into a link to the relevant type's API docs
Configuration menu - View commit details
-
Copy full SHA for 04f122e - Browse repository at this point
Copy the full SHA 04f122eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 321bb68 - Browse repository at this point
Copy the full SHA 321bb68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b5da7e - Browse repository at this point
Copy the full SHA 5b5da7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbcd086 - Browse repository at this point
Copy the full SHA bbcd086View commit details -
Move
Binary
trait intocrate::types::buffer::private
so it doesn'……t show up in docs.
Configuration menu - View commit details
-
Copy full SHA for 9172444 - Browse repository at this point
Copy the full SHA 9172444View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9db2163 - Browse repository at this point
Copy the full SHA 9db2163View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff4e501 - Browse repository at this point
Copy the full SHA ff4e501View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a49e5b - Browse repository at this point
Copy the full SHA 1a49e5bView commit details -
- Change
from_array_buffer()
tofrom_buffer_region()
and add more…… convenient `from_buffer()` - Add `TypedArray::byte_length()` - Add `JsTypedArray::{byte_offset, buffer}` - Revert visibility of Binary back to public to enable typed array abstractions - Add tests for buffer aliasing and argument validation - Add tests for `byte_length`, `byte_offset`, and `buffer` methods
Configuration menu - View commit details
-
Copy full SHA for 84c5fd8 - Browse repository at this point
Copy the full SHA 84c5fd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbf3cda - Browse repository at this point
Copy the full SHA bbf3cdaView commit details -
Make
JsTypedArray
into a wide pointer (likeJsBox
) that caches al……l the metadata, avoiding extra FFI calls to retrieve that data.
Configuration menu - View commit details
-
Copy full SHA for 45780d5 - Browse repository at this point
Copy the full SHA 45780d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e119b79 - Browse repository at this point
Copy the full SHA e119b79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03c0cf9 - Browse repository at this point
Copy the full SHA 03c0cf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 776ba84 - Browse repository at this point
Copy the full SHA 776ba84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f0fc4c - Browse repository at this point
Copy the full SHA 3f0fc4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffb089b - Browse repository at this point
Copy the full SHA ffb089bView commit details
Commits on Jul 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 480298c - Browse repository at this point
Copy the full SHA 480298cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5785b96 - Browse repository at this point
Copy the full SHA 5785b96View commit details -
Add a
Region
type to represent a typed region of a buffer:- Shorten `from_buffer_region` to `from_region` - Add symmetric `to_region` method, which only requires a single `napi_get_typed_array_info` FFI call
Configuration menu - View commit details
-
Copy full SHA for 6bc6aaa - Browse repository at this point
Copy the full SHA 6bc6aaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cf8c53 - Browse repository at this point
Copy the full SHA 9cf8c53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28b6136 - Browse repository at this point
Copy the full SHA 28b6136View commit details -
Configuration menu - View commit details
-
Copy full SHA for 912b178 - Browse repository at this point
Copy the full SHA 912b178View commit details
Commits on Aug 1, 2022
-
Update for latest RFC changes:
- byte_offset -> offset - byte_length -> size - to_region -> region - to_typed_array and region take &self - JsArrayBuffer::region static method, for doc discoverability
Configuration menu - View commit details
-
Copy full SHA for f24f1e7 - Browse repository at this point
Copy the full SHA f24f1e7View commit details -
- API tweak: TypedArray::Item must implement Binary
- add tests about region validation
Configuration menu - View commit details
-
Copy full SHA for 74251cb - Browse repository at this point
Copy the full SHA 74251cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 326a9d0 - Browse repository at this point
Copy the full SHA 326a9d0View commit details
Commits on Aug 28, 2022
-
- make doc-related crates (doc-comment, aquamarine) optional - `Binary` only requires `Clone`, not `Copy` or `Debug` - `Region` API changes * still impls Copy but all its methods take a reference * range checks throw `RangeError` instead of panicking - minor code improvements * copy-editing nit in doc comment * `buffer/types.rs` imports from `types_impl` not `types` so it's clear why it has private access * use `map_err` to clean up some code * simplify `detach` test helper function
Configuration menu - View commit details
-
Copy full SHA for aa6c655 - Browse repository at this point
Copy the full SHA aa6c655View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6c2143 - Browse repository at this point
Copy the full SHA f6c2143View commit details
Commits on Sep 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7fb1779 - Browse repository at this point
Copy the full SHA 7fb1779View commit details