Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(neon): Add JoinHandle as a result of Channel::send #787

Merged
merged 1 commit into from
Sep 14, 2021
Merged

feat(neon): Add JoinHandle as a result of Channel::send #787

merged 1 commit into from
Sep 14, 2021

Conversation

kjvalencik
Copy link
Member

@kjvalencik kjvalencik force-pushed the kv/join-handle branch 2 times, most recently from 7a90ca0 to 16ee297 Compare September 3, 2021 18:54
@kjvalencik kjvalencik mentioned this pull request Sep 13, 2021
Merged
dherman
dherman approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Maybe some comments in the test, which has kind of intricate control flow, would help. But it's up to you.

src/event/event_queue.rs Show resolved Hide resolved
test/napi/lib/threads.js Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Sep 14, 2021 •
edited
Loading

✔️ Deploy Preview for neon-bindings-docs ready!

🔨 Explore the source changes: 390877f

🔍 Inspect the deploy log: https://app.netlify.com/sites/neon-bindings-docs/deploys/6140f03096486123953d06c3

😎 Browse the preview: https://deploy-preview-787--neon-bindings-docs.netlify.app

@kjvalencik kjvalencik merged commit ebc5192 into next/0.10 Sep 14, 2021
@kjvalencik kjvalencik deleted the kv/join-handle branch September 14, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherman dherman dherman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjvalencik @dherman