fix(neon): Require TryFromJs::Error to implement TryIntoJs
#1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjvalencik
commented
Oct 2, 2024
kjvalencik
commented
Oct 2, 2024
kjvalencik
commented
Oct 2, 2024
kjvalencik
commented
Oct 2, 2024
dherman
approved these changes
Oct 7, 2024
kjvalencik
force-pushed
the
kv/try-from-error
branch
from
30a8201
to
b548935
Compare
Additionally: * Replace `TryFromJs::from_js` implementations with a default * Add a `json::Error` wrapper to hide implementation details
kjvalencik
force-pushed
the
kv/try-from-error
branch
from
b548935
to
3721a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally:
TryFromJs::from_jsimplementations with a defaultjson::Errorwrapper to hide implementation detailsThis will be important for implementing
TryFromJsoneither::Either. Without this requirement, we would either need acx.try_catch(..)or to discard theLefterror in theTryFromJs::from_jsimplementation.