Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace multiple factories with one factory #44

Closed
neomerx opened this issue Jul 8, 2015 · 2 comments
Closed

Replace multiple factories with one factory #44

neomerx opened this issue Jul 8, 2015 · 2 comments
Assignees
@neomerx
Labels
enhancement
Milestone
1.0

Comments

@neomerx
Copy link
Owner

neomerx commented Jul 8, 2015

The package uses multiple factories for its components. If replaced with one factory it will simplify package extensions.
@neomerx neomerx self-assigned this Jul 8, 2015
@neomerx neomerx added this to the 1.0 milestone Jul 8, 2015
neomerx added a commit that referenced this issue Jul 8, 2015
@neomerx
Closes #44 Refactor factories into one factory
aa7458e
@neomerx
Copy link
Owner Author

neomerx commented Jul 8, 2015

People who use #40 should be notified with this update

@neomerx
Copy link
Owner Author

neomerx commented Jul 8, 2015

Shortly

  • instead of extending multiple factories developers should extend \Neomerx\JsonApi\Factories\Factory
  • method Encoder::getFactories was replaced with Encoder::getFactory and should return FactoryInterface (which is extension for all factory interfaces in the package)

neomerx added a commit that referenced this issue Jul 12, 2015
@neomerx
Add lazy relationship load for #44
6c0689a
neomerx added a commit that referenced this issue Jul 12, 2015
@neomerx
Add lazy relationship load for #44
3e5774c
neomerx added a commit that referenced this issue Jul 12, 2015
@neomerx
Add skip evaluation of hidden relationships for #44
4906bcb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neomerx neomerx

Labels
enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@neomerx