Skip to content

Conversation

@neotrow
Copy link
Contributor

@neotrow neotrow commented Jun 2, 2025

No description provided.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 2, 2025

Open in StackBlitz

npm i https://pkg.pr.new/neolution-ch/react-data-table/@neolution-ch/react-data-table@79

commit: 090eb51

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces two optional flags to control the row striping and clear-search-button visibility in ReactDataTable.

  • Add isStriped prop to toggle striped rows (default: true)
  • Add showClearSearchButton prop to show/hide the clear search icon (default: true)
  • Wire props through component defaults and update changelog

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/lib/ReactDataTable/ReactDataTableProps.ts Define isStriped and showClearSearchButton props with JSDoc
src/lib/ReactDataTable/ReactDataTable.tsx Destructure new props, apply striped={isStriped} and conditional clear button
CHANGELOG.md Document new flags under the "Unreleased" section
Comments suppressed due to low confidence (2)

src/lib/ReactDataTable/ReactDataTableProps.ts:112

  • Update the JSDoc for showClearSearchButton—it currently mentions a hover effect but should describe toggling the clear search button visibility.
*   boolean flag to indicate if the table should have hover effect

src/lib/ReactDataTable/ReactDataTable.tsx:48

  • Add unit or integration tests to verify that isStriped correctly applies or removes the striping class, and that showClearSearchButton shows or hides the clear icon as expected.
isStriped = true,

@neotrow neotrow requested a review from manni497 June 2, 2025 11:00
@neotrow neotrow merged commit 4911951 into main Jun 3, 2025
6 checks passed
@neotrow neotrow deleted the feature/stripped-flag branch June 3, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants