feat: add fixed position support for floating windows #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5217 +/- ##
==========================================
- Coverage 97.39% 97.38% -0.02%
==========================================
Files 291 291
Lines 27021 27026 +5
Branches 5600 5605 +5
==========================================
+ Hits 26317 26319 +2
- Misses 495 496 +1
- Partials 209 211 +2 ☔ View full report in Codecov by Sentry. |
fannheyward
approved these changes
Dec 7, 2024
Closed
fannheyward
added a commit
that referenced
this pull request
Dec 24, 2024
a6e54ae fix(client): `shell=true` on windows (#5225) dce5ae5 feat(plugin): improve argument typing (#5221) 77094cb docs: correct coc-example-config url (#5220) 1e7abfa feat(scope): ensureDocument can accept bufnr (#5219) 28ad86d feat: add fixed position support for floating windows (#5217) 6a338ca fix(codeLens): Misalign when using tabs as indent (#5214) 306d7b9 fix(plugin): gramma on Action not existing (#5213) 5ca97f5 chore: correct typos (#5212) 2816a11 chore(history.md): mentioned recently improvements (#5211) d70a46d refactor(highlights): remove checkMarkers (#5210) 829a106 perf(highlight): increase number of highlights (#5208) 2fc3f0d fix(semanticTokens): correct end range (#5206) 00da052 feat(semanticTokens): decrease highlighting range (#5205)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature to support fixed positioning for floating windows.
Sometimes while coding, I find the diagnostic floating windows can be distracting as they often overlap with the code I'm trying to read. Many diagnostics are temporary and appear during the coding process, and I don't always need to see these less important diagnostic messages. However, they still pop up large floating windows that disrupt my focus.
I took inspiration from Helix editor's diagnostic design, which displays the current cursor's diagnostic message in a fixed position at the top-right corner of the editor. I find this design very effective as it keeps the main editing area clean and uncluttered.
This implementation allows for a more focused coding experience.