Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): set foldcolumn to 0 since it isn't applicable #4929

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

mehalter
Copy link
Contributor

@mehalter mehalter commented Mar 7, 2024

If the user uses foldcolumn then the list buffers have an extra column that is not useful especially for a buffer that is bound to only be in insert mode. This locally sets foldcolumn=0

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (dd4a5fa) to head (5535f48).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4929   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files         273      273           
  Lines       26077    26077           
  Branches     5392     5392           
=======================================
  Hits        25706    25706           
+ Misses        218      217    -1     
- Partials      153      154    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mehalter
Copy link
Contributor Author

mehalter commented Mar 7, 2024

Not sure what's happening with the tests here, seems unrelated to the chance made in the PR 🤔 Let me know if there's anything I should look into! Thanks 😄

@fannheyward fannheyward merged commit 0cf3c4c into neoclide:master Mar 8, 2024
3 of 4 checks passed
@mehalter mehalter deleted the list_foldcolumn branch March 8, 2024 03:17
fannheyward added a commit that referenced this pull request Mar 11, 2024
84ce031 chore(doc): move coc-example-config.* to doc
1238cfc chore: typos (#4931)
37bb3c3 chore(docs): add coc-example-config in vim/lua (#4930)
0cf3c4c fix(list): set foldcolumn to 0 since it isn't applicable (#4929)
dd4a5fa fix(language-client): register DiagnosticRefreshRequest (#4928)
96d43df feat(outline): add outline.autoHide (#4926)
bd303cf feat(language-client): round progress percentage (#4916)
7f8ae84 fix(model): fire onTextChange on TextChangedI (#4875)
@fannheyward
Copy link
Member

@all-contributors please add @mehalter for code.

Copy link
Contributor

@fannheyward

I've put up a pull request to add @mehalter! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants