Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspaceFolder): support wildcard for bottomUpFiletypes #3854

Merged
merged 4 commits into from
May 28, 2022

Conversation

kevinhwang91
Copy link
Contributor

{
    "workspace.workspaceFolderCheckCwd": false,
    "workspace.bottomUpFiletypes": ["*"],
}

is extremely useful for the git submodule to find a correct workspace.

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #3854 (f9cdcfe) into master (aede54f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3854   +/-   ##
=======================================
  Coverage   82.05%   82.06%           
=======================================
  Files         223      223           
  Lines       23295    23295           
  Branches     5179     5180    +1     
=======================================
+ Hits        19114    19116    +2     
  Misses       2433     2433           
+ Partials     1748     1746    -2     
Impacted Files Coverage Δ
src/core/workspaceFolder.ts 88.99% <100.00%> (ø)
src/core/editors.ts 90.00% <0.00%> (-2.86%) ⬇️
src/snippets/session.ts 91.30% <0.00%> (-0.40%) ⬇️
src/list/session.ts 91.17% <0.00%> (+0.26%) ⬆️
src/list/ui.ts 92.85% <0.00%> (+0.29%) ⬆️
src/handler/semanticTokens/buffer.ts 88.34% <0.00%> (+0.37%) ⬆️
src/languages.ts 95.00% <0.00%> (+0.41%) ⬆️
src/completion/floating.ts 91.66% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aede54f...f9cdcfe. Read the comment docs.

@fannheyward fannheyward merged commit 250e81f into neoclide:master May 28, 2022
chemzqm added a commit that referenced this pull request May 28, 2022
bb448eb fix(documents): synchronize before willSave
d455ed9 fix(doc): fix bad tags
7b04e8b refactor(doc): use coc-config.txt
9cf278d fix(jest): clean up tmp after exit (#3855)
49238dd fix(semanticTokens): check delta.data (#3853)
250e81f feat(workspaceFolder): support wildcard for bottomUpFiletypes (#3854)
@kevinhwang91 kevinhwang91 deleted the all-ft-botup branch September 23, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants