Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correcting verbiage of install message #3555

Merged
merged 1 commit into from
Jan 11, 2022
Merged

chore: Correcting verbiage of install message #3555

merged 1 commit into from
Jan 11, 2022

Conversation

rschristian
Copy link
Contributor

"remains" isn't the correct form of the word.

I elected to only change the form of the word in the message, rather than also correct the method and variable declaration. I'm not super familiar with what pieces might be a public API, and correcting them would serve no functional purpose.

Let me know if you want these updated and are safe to do so.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #3555 (2a5df59) into master (8f2a2dc) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3555      +/-   ##
==========================================
+ Coverage   74.69%   74.73%   +0.03%     
==========================================
  Files         191      191              
  Lines       19554    19554              
  Branches     4384     4384              
==========================================
+ Hits        14606    14613       +7     
+ Misses       3169     3161       -8     
- Partials     1779     1780       +1     
Impacted Files Coverage Δ
src/model/installBuffer.ts 69.23% <0.00%> (ø)
src/extensions.ts 57.97% <0.00%> (-0.17%) ⬇️
src/handler/semanticTokensHighlights/buffer.ts 76.47% <0.00%> (+5.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f2a2dc...2a5df59. Read the comment docs.

@chemzqm chemzqm merged commit 136ef00 into neoclide:master Jan 11, 2022
@rschristian rschristian deleted the rschristian-patch-1 branch January 12, 2022 10:57
chemzqm added a commit that referenced this pull request Jan 12, 2022
ee2c44a feat(codelens): use virt_lines_above when possible
239ebc4 chore(package): update vscode-languageserver-textdocument
2ae5e37 feat(diagnostic): more config for diagnostic level
87239c2 fix(snippets): fix date variables format
95eafa8 chore(typings): add languageId to Document
34fae82 feat(model): add document.lineAt function (#3520)
c0b8a83 chore(esbuild): fix file mode
73db30b chore(package): Upgrade node-client
7a34631 fix(sources): extend file sources regex (#3559)
136ef00 chore: Correcting verbiage of install message (#3555)
366b632 make CocLocations return bool (#3545)
10c3a7b chore(README): use CocActionAsync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants