LSP 3.16.0 #2756

fannheyward · 2020-12-22T12:50:45Z

Major features in LSP 3.16:

What's have done:

vscode-languageserver-protocol, vscode-languageserver-types to 3.16.0
use RegistrationType microsoft/vscode-languageserver-node@bb85e80
~~add client.end, microsoft/vscode-languageserver-node@44ab977, but breaks src/__tests__/client/features.test.ts~~
LanguageClientOptions adds connectionOptions and markdown
new capabilites, disabled by default, needs more to test
completionItem.insertTextModeSupport
Call Hierarchy provider and manager
Call Hierarchy tests passed src/__tests__/client/features.test.ts
call CocAction('incomingCalls') and :call CocAction('outgoingCalls') work, use list UI for now, a better tree view UI is needed Support call hierarchies #1649
resolveCodeAction support, tests passed
WindowMiddleware and ShowDocumentRequest support
add SemanticTokensFeature
:call CocAction('semanticHighlight')
LinkedEditingRanges API ready
fileOperations is working, tests passed!
willRename event is added in workspace.renameCurrentFile, tested with rust-analyzer and it works!

Steps to test semanticTokens highlights (nvim 0.5 is needed):

define CocSem_{tokenType} in vimrc, for example hi! link CocSem_semicolon Variable
you can get all tokenTypes by :call CocActionAsync('showSemanticHighlightInfo')

Thanks to @statiolake's codes and tests, the semanticTokens highlights are working for full document, still needs improvement on delta update

UI for Call Hierarchy, tree view?
coc-json/coc-html/coc-css needs upgrade microsoft/vscode@a22b5d5#diff-c953a54ba3e8cb1ac4d9b1b35daa451698e1d5a4975d38d26ad07741aa0a5d60

fannheyward · 2021-01-02T10:51:24Z

The tests are failed because client.end, still haven't found the reason. If I revert this, tests still fails.

fannheyward · 2021-01-04T10:16:49Z

I've reverted client.end, from LSP spec, https://microsoft.github.io/language-server-protocol/specifications/specification-current/#shutdown, client only needs to do shutdown - exit, no end.

chemzqm · 2021-01-12T12:15:33Z

workspace.registerBufferSync and buffer.highlightRanges can be used for semantic tokens

chemzqm · 2021-06-09T10:17:02Z

package.json

@@ -61,7 +61,7 @@
    "@types/marked": "^1.2.1",
    "@types/minimatch": "^3.0.3",
    "@types/mkdirp": "^1.0.1",
-    "@types/node": "^10.12.0",
+    "@types/node": "12.12.12",


We should support node 10.12.0, avoid upgrade types.

node 10 is EOL in April 2021, maybe we can start from node 12? https://nodejs.org/en/about/releases/

There're two reason I bump it to node 12:

errors from tsc -p tsconfig.json shows that Namespace '"fs"' has no exported member 'Dir' from fs-extra.

cp.SpawnOptionsWithoutStdio in 06e4b6c, the createMessageTransports changes.

node 10 is EOL in April 2021, maybe we can start from node 12? https://nodejs.org/en/about/releases/

Ok, we need update check for node version as well

https://github.com/neoclide/coc.nvim/blob/feat/lsp-316/plugin/coc.vim#L422
https://github.com/neoclide/coc.nvim/blob/feat/lsp-316/esbuild.js#L45
https://github.com/neoclide/coc.nvim/blob/feat/lsp-316/autoload/health/coc.vim#L27

Limit to 12.12, is the minor version ok? (the minor 12 just jumped into my mind without any search/tests...

src/language-client/index.ts

chemzqm · 2021-06-09T11:03:44Z

src/provider/semanticTokensManager.ts

+  private _legend: SemanticTokensLegend
+
+  public register(selector: DocumentSelector, provider: DocumentSemanticTokensProvider, legend: SemanticTokensLegend): Disposable {
+    this._legend = legend


Seems different document could have different legend, can be added to item.

The legend is came from LS in initialize request, it's not document related. Did I misunderstand something?

coc requests with all tokenTypes and tokenModifiers, LS responses supported legend, so I don't think it's document related.

I've check the doc, it is language server related, so different language server could have different SemanticTokensLegend.

Should be property of DocumentSemanticTokensProvider

SemanticTokensManager has legend property, is this what you expect?

Also DocumentRangeSemanticTokensProvider

DocumentRangeSemanticTokensProvider missed a lot, will update it ASAP.

is 004ab14 ok?

https://github.com/neoclide/coc.nvim/blob/feat/lsp-316/src/languages.ts#L433 need be replaced with a function that accept document, which return legend from matched provider when possible.

src/provider/semanticTokensRangeManager.ts

needs neoclide/coc.nvim#2756 closes neoclide#128

needs neoclide/coc.nvim#2756 closes #128

chemzqm · 2021-06-15T06:17:47Z

Model src/handler/semanticTokensHighlights/buffer.ts can be improved, I will make some updates.

91c1114 fix(diagnostic): avoid change range of diagnostics cad8c6b fix(workspace): fix range of getSelectedRange with line mode 18f81ab chore(picker): use await to avoid test fail 3efce54 fix(diagnostic): no more emptyRange check (#3147) 837941f fix float window position control to consider multigrid ui (#3150) 046505c test(ci): use node12 acd723d fix(completion): avoid unnecessary redraw for floating window (#3151) 10cfe59 docs: inconsistent suggest.triggerCompletionWait value (#3152) dafed9d fix: remove polyfill of Promise.prototyp.finally (#3153) 493ea2e fix(diagnostic): check diagnostic next to eol character 31e76d4 refactor(handler): fetch codelens for all buffers on CursorHold e47e472 fix(diagnostic): adjust diagnostic range which pass last line ba9c5c8 chore(yarn): upgrade esbuild.js 9b60af3 chore(bin): remove unnecessary check.js 179ca72 fix: typos found by github.com/crate-ci/typos (#3146) 70a7903 LSP 3.16.0 (#2756) 8cb6bdc fix(float): should give foldcolumn a default value (#3140) 171ff2b chore(bin): remove unnecessary check.js 1377f3b fix: yarn.lock (#3136)

ssh352 · 2022-06-25T09:12:52Z

the Call Hierarchy doesn't support filter
CocOutline window supports filter though.

fannheyward force-pushed the feat/lsp-316 branch 8 times, most recently from 81e5ef6 to 551e4d9 Compare December 25, 2020 03:36

fannheyward marked this pull request as ready for review December 25, 2020 10:36

onichandame mentioned this pull request Dec 26, 2020

[bug | question] The "docker" server crashed josa42/coc-docker#45

Closed

fannheyward force-pushed the feat/lsp-316 branch 8 times, most recently from 0171ba9 to 889f911 Compare January 2, 2021 08:07

fannheyward force-pushed the feat/lsp-316 branch from 889f911 to 78600a6 Compare January 4, 2021 01:39

fannheyward force-pushed the feat/lsp-316 branch 2 times, most recently from 7648463 to d9e7321 Compare January 7, 2021 08:28

This comment has been minimized.

Sign in to view

fannheyward force-pushed the feat/lsp-316 branch 4 times, most recently from c80fa1f to 43c8c2b Compare January 12, 2021 01:36

fannheyward force-pushed the feat/lsp-316 branch from 56f9cb5 to ec99b6c Compare January 14, 2021 08:03

fannheyward added 6 commits June 8, 2021 18:19

fix(handler): semanticTokens legend

deb4765

feat(client): completionItem#resolveSupport

c722a72

feat(language-clent): process.env.LANG as locale

4a191b1

feat: rename to hasSemanticTokensEdits

1013b3e

feat(languages): hasLinkedEditing

6774cf1

chore(language-client): format

d42a929

fannheyward force-pushed the feat/lsp-316 branch from 1487f6c to d42a929 Compare June 8, 2021 10:19

chore: typings

949ce39

chemzqm reviewed Jun 9, 2021

View reviewed changes

src/language-client/index.ts Outdated Show resolved Hide resolved

fix(language-client): unused ENV

32f954b

chemzqm reviewed Jun 9, 2021

View reviewed changes

src/provider/semanticTokensRangeManager.ts Outdated Show resolved Hide resolved

feat(plugin): check nodejs 12.12

220ac95

fannheyward added a commit to fannheyward/coc-tsserver that referenced this pull request Jun 10, 2021

feat: callHierarchy support

55a22ab

needs neoclide/coc.nvim#2756 closes neoclide#128

fannheyward mentioned this pull request Jun 10, 2021

feat: callHierarchy support neoclide/coc-tsserver#297

Merged

chore: nodejs 12 is needed

4cc20b6

fannheyward added a commit to fannheyward/coc-tsserver that referenced this pull request Jun 10, 2021

feat: callHierarchy support

33b46c0

needs neoclide/coc.nvim#2756 closes neoclide#128

chemzqm pushed a commit to neoclide/coc-tsserver that referenced this pull request Jun 10, 2021

feat: callHierarchy support (#297)

f76e310

needs neoclide/coc.nvim#2756 closes #128

fannheyward added 4 commits June 10, 2021 16:40

feat(provider): provideDocumentRangeSemanticTokens

29d5927

feat: DocumentSemanticTokensProvider.legend

004ab14

feat(languages): getLegend

a62f585

fix(handler): full on showSemanticHighlightInfo

b575917

chemzqm merged commit 70a7903 into master Jun 15, 2021

chemzqm deleted the feat/lsp-316 branch June 15, 2021 06:17

oblitum mentioned this pull request Jun 15, 2021

Support semantic tokens #2053

Closed

fannheyward mentioned this pull request May 11, 2022

"await client.stop()" outputs an error. #3812

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LSP 3.16.0 #2756

LSP 3.16.0 #2756

fannheyward commented Dec 22, 2020 •

edited

Loading

fannheyward commented Jan 2, 2021

fannheyward commented Jan 4, 2021

This comment has been minimized.

chemzqm commented Jan 12, 2021

chemzqm Jun 9, 2021

fannheyward Jun 9, 2021 •

edited

Loading

fannheyward Jun 9, 2021 •

edited

Loading

chemzqm Jun 9, 2021

fannheyward Jun 9, 2021 •

edited

Loading

chemzqm Jun 9, 2021

fannheyward Jun 10, 2021 •

edited

Loading

chemzqm Jun 10, 2021

chemzqm Jun 10, 2021

fannheyward Jun 10, 2021

chemzqm Jun 10, 2021

fannheyward Jun 10, 2021

fannheyward Jun 10, 2021

chemzqm Jun 10, 2021 •

edited

Loading

fannheyward Jun 11, 2021

chemzqm commented Jun 15, 2021

ssh352 commented Jun 25, 2022

LSP 3.16.0 #2756

LSP 3.16.0 #2756

Conversation

fannheyward commented Dec 22, 2020 • edited Loading

fannheyward commented Jan 2, 2021

fannheyward commented Jan 4, 2021

This comment has been minimized.

chemzqm commented Jan 12, 2021

Choose a reason for hiding this comment

fannheyward Jun 9, 2021 • edited Loading

Choose a reason for hiding this comment

fannheyward Jun 9, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fannheyward Jun 9, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fannheyward Jun 10, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chemzqm Jun 10, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chemzqm commented Jun 15, 2021

ssh352 commented Jun 25, 2022

fannheyward commented Dec 22, 2020 •

edited

Loading

fannheyward Jun 9, 2021 •

edited

Loading

fannheyward Jun 9, 2021 •

edited

Loading

fannheyward Jun 9, 2021 •

edited

Loading

fannheyward Jun 10, 2021 •

edited

Loading

chemzqm Jun 10, 2021 •

edited

Loading