fix: adjust copen height when enable useQuickfixForLocations #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default height of `copen` is 10, if the items are less than 10, we should set height manually to make the behavior like default coclist's.
kevinhwang91
force-pushed
the
fix-showlocation
branch
from
7183c18 to
a76f285
Compare
kevinhwang91
commented
Oct 8, 2020
| @@ -719,7 +719,9 @@ export class Workspace implements IWorkspace { | |||
| const preferences = this.getConfiguration('coc.preferences') | |||
| if (preferences.get<boolean>('useQuickfixForLocations', false)) { | |||
| let openCommand = await nvim.getVar('coc_quickfix_open_command') as string | |||
| nvim.command(typeof openCommand === 'string' ? openCommand : 'copen', true) | |||
There was a problem hiding this comment.
I have no idea why execute two times of openCommand. Could I delete it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default height of
copenis 10, if the items are less than 10,we should set height manually to make the behavior like default coclist's.