Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(util): add g:coc_data_home #1529

Merged
merged 4 commits into from
Feb 10, 2020
Merged

feat(util): add g:coc_data_home #1529

merged 4 commits into from
Feb 10, 2020

Conversation

fannheyward
Copy link
Member

used for coc data files location.

close #1528

@fannheyward
feat(util): add g:coc_data_home
2d8cfca 
used for coc data files location.
close #1528
@fannheyward
Copy link
Member Author

fannheyward commented Feb 6, 2020 •
edited
Loading

yarn test is broken, WIP. fixed

@oblitum oblitum mentioned this pull request Feb 7, 2020
Closed
@oblitum
Copy link
Member

oblitum commented Feb 7, 2020

Ready to merge? I reviewed it and it seems fine.

@fannheyward
Copy link
Member Author

fannheyward commented Feb 10, 2020 •
edited
Loading

Ping @chemzqm , any thoughts on adding g:coc_data_home?

@chemzqm
Copy link
Member

chemzqm commented Feb 10, 2020

We can add a warning in coc#util#extension_root function when g:coc_extension_root exists and use g:coc_data_home instead when it's exits.

@fannheyward fannheyward merged commit e733dca into master Feb 10, 2020
@fannheyward fannheyward deleted the feat/coc_data_home branch February 10, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oblitum oblitum oblitum approved these changes

@chemzqm chemzqm chemzqm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting up g:coc_config_home does nothing
3 participants
@fannheyward @oblitum @chemzqm