Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest release commit (8909a94) broke coc_global_extensions #1881

Closed
npearson72 opened this issue May 9, 2020 · 12 comments
Closed

Latest release commit (8909a94) broke coc_global_extensions #1881

npearson72 opened this issue May 9, 2020 · 12 comments

Comments

@npearson72
Copy link

npearson72 commented May 9, 2020 •
edited
Loading

They just don't work on a fresh install. No extensions get installed. Nothing in the package.json.

When I revert to 244b439 they work just fine.

Sorry for not filling out all the details as typical in a bug report, but this should be easily reproducible.
@azhang
Copy link

azhang commented May 9, 2020

wow good to see this as I've spent the last 2 hours trying to figure out why it wasn't working. First time coc user -_-

@nkcfan
Copy link

nkcfan commented May 9, 2020 

8909a94 2020-05-09 | chore(plugin): use eslint replace tslint (origin/release) [Qiming Zhao]

This commit also broke ccls. I have spent the last 1 hour trying to figure out why a node upgrade broke everything, finally not a node issue.

@npearson72
Copy link
Author

I propose rolling it back, but am not familiar with your workflow.

@Alexey104
Copy link

Alexey104 commented May 10, 2020 •
edited
Loading

The same problem.
Language servers also stopped working.

@fsouza fsouza mentioned this issue May 10, 2020
Merged
@fsouza
Copy link
Contributor

fsouza commented May 10, 2020

Yeah after that change external processes are not launching anymore. Any laguageserver will simply not start.

I have a potential fix in #1882, but there's a chance other similar errors happened as part . I'd recommend reviewing all changes from !== false or === false to simple truthy checks.

@oblitum
Copy link
Member

oblitum commented May 10, 2020

Duplicate of #1878.

@oblitum oblitum closed this as completed May 10, 2020
chemzqm pushed a commit that referenced this issue May 10, 2020
@fsouza
services: fix config check in process start (#1882)
ed722a1 
LanguageServerConfig.enable was mistyped and the linter got it wrong.
There's a chance this is happening in other places, I'd recommend
reviewing all changes from `!== false` or `=== false` to simple truthy
checks.

Related to #1881.

Co-authored-by: francisco souza <fsouza@users.noreply.github.com>
@npearson72 npearson72 mentioned this issue May 11, 2020
Closed
@chemzqm
Copy link
Member

chemzqm commented May 11, 2020

@fsouza I've did a review and fixed similar issues which caused by eslint autofix with no-unnecessary-boolean-literal-compare set to error

@fsouza
Copy link
Contributor

fsouza commented May 11, 2020

@chemzqm thank you very much!

@npearson72
Copy link
Author

@fsouza, @oblitum, and @chemzqm I just tested on release commit 97b6e17533574c016a484030c8041b19a7cde400 and still not working.

Should I be using master?

@chemzqm chemzqm reopened this May 11, 2020
@chemzqm
Copy link
Member

chemzqm commented May 11, 2020

It's not fixed

fnichol added a commit to fnichol/dotvim that referenced this issue May 11, 2020
@fnichol
[coc.nvim] Pin to 244b439 to mitigate regression
8ae6ac7 
References:

* neoclide/coc.nvim#1881
* neoclide/coc.nvim#1878

Signed-off-by: Fletcher Nichol <fnichol@nichol.ca>
fannheyward added a commit that referenced this issue May 12, 2020
@fannheyward
fix(extensions): fix coc_global_extensions error
75f8290 
close #1881
@fannheyward fannheyward mentioned this issue May 12, 2020
Closed
@glepnir
Copy link
Contributor

glepnir commented May 12, 2020

got same error here.

chemzqm added a commit that referenced this issue May 12, 2020
@chemzqm
fix(extensions): fix filter of global extensions
deaba42 
Closes #1881
@npearson72
Copy link
Author

Thank you @chemzqm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(extensions): fix coc_global_extensions error neoclide/coc.nvim
8 participants
@fsouza @chemzqm @azhang @oblitum @npearson72 @nkcfan @Alexey104 @glepnir