fix: add domain name for fqdn if host has short name

[Tiboris]

Append the meta_domain["name"] to the hostname
of the resource where name is not fqdn to get one

Signed-off-by: Tibor Dudlák tdudlak@redhat.com

[pvoborni]

Approving.

Though I was wondering if we should attempt to fix typos like: hostname = "short.bar.testt", domain = "bar.test". In this case shortname will be: short and fqdn will be: short.bar.testt.bar.test. Alternative implementation can be also get_shortname(name) + "." + dom_nam. But I'm not sure what is better.

[pvoborni]

I think we should also extend https://github.com/neoave/mrack/blob/master/tests/unit/test_ansible_inventory.py with tests to ensure that hostname, fqdn are generated according to expectations to prevent future regressions. Could be a separate PR. Will you write it or should I?

[pvoborni]

For referene, verified via:

Input:

domains:
  - name: foo.bar
    type: ipa
    hosts:
      # FQDN
      - name: first.foo.bar
        role: master
        group: ipaserver
        os: rhel-8.4
      # Short name
      - name: client
        role: client
        group: ipaserver
        os: rhel-8.4
      # Invalid name as it is FQDN which does not belong into domain
      - name: client2.invalid
        role: client
        group: ipaserver
        os: rhel-8.4
      # Invalid name as it is FQDN with a sub domain - should be defined as
      # a separate domain
      - name: client2.invalid.foo.bar
        role: client
        group: ipaserver
        os: rhel-8.4

output, reduced to 4 variables per host:

2021-11-25T15:33:42       hosts:
2021-11-25T15:33:42         client:
2021-11-25T15:33:42           meta_dc_record: DC=foo,DC=bar
2021-11-25T15:33:42           meta_domain: foo.bar
2021-11-25T15:33:42           meta_fqdn: client.foo.bar
2021-11-25T15:33:42           meta_hostname: client
2021-11-25T15:33:42         client2.invalid:
2021-11-25T15:33:42           meta_dc_record: DC=foo,DC=bar
2021-11-25T15:33:42           meta_domain: foo.bar
2021-11-25T15:33:42           meta_fqdn: client2.foo.bar
2021-11-25T15:33:42           meta_hostname: client2
2021-11-25T15:33:42         client2.invalid.foo.bar:
2021-11-25T15:33:42           meta_dc_record: DC=foo,DC=bar
2021-11-25T15:33:42           meta_domain: foo.bar
2021-11-25T15:33:42           meta_fqdn: client2.foo.bar
2021-11-25T15:33:42           meta_hostname: client2
2021-11-25T15:33:42         first.foo.bar:
2021-11-25T15:33:42           meta_dc_record: DC=foo,DC=bar
2021-11-25T15:33:42           meta_domain: foo.bar
2021-11-25T15:33:42           meta_fqdn: first.foo.bar
2021-11-25T15:33:42           meta_hostname: first