Fix handling of large chunks #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driver used to only accept chunks of size 32767. This was a limitation on the total chunk size, which includes a 2 byte length header and body. However, Bolt protocol specification allows chunks with body of size 65535 (0xFFFF). This commit fixes the problem by making `ChunkDecoder` accept chunks of size 65535 + 2.
Driver tries to extract cause of every `CodecException` received in `#exceptionCaught(Throwable)` netty callbacks. It did not handle cases when the cause is null, which resulted in an attempt to exceptionally complete a `CompletableFuture` with null. This commit fixes the problem by making handlers extract the exception cause only if it is defined and propagate the original error otherwise.
ali-ince
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.