Fixed a bug found on idle and inUse counters #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2018 17:00
Before we always decrement idle counters when a channel is closed. However, this is wrong when a channel is closed before it is returen to the pool. So change the code to make sure that no matter the channel is closed inside or outside the pool, the idle and inUse counters should be correct.
zhenlineo
force-pushed
the
1.6-idle-counter
branch
from
a41a02a to
30797ec
Compare
lutovich
approved these changes
Mar 6, 2018
| assertEquals( 0, tracker.idleChannelCount( address ) ); | ||
|
|
||
| // When closed before session.close | ||
| channel.close(); |
Contributor
There was a problem hiding this comment.
Maybe channel.close().sync()?
Channel#close() is async and returns a future.
| assertEquals( 1, tracker.idleChannelCount( address ) ); | ||
|
|
||
| // When closed before acquire | ||
| channel.close(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we always decrement idle counters when a channel is closed. However, this is wrong when a channel is closed before it is returen to the pool.
So change the code to make sure that no matter the channel is closed inside or outside the pool, the idle and inUse counters should be correct.