Skip to content

test: fix SessionIT, AsyncSessionIT, AsyncTransactionIT run failures #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
+15 −15
Merged

test: fix SessionIT, AsyncSessionIT, AsyncTransactionIT run failures #1697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions driver/src/test/java/org/neo4j/driver/integration/SessionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,9 +680,9 @@ public String execute(Transaction tx) {
void shouldThrowRunFailureImmediatelyAndCloseSuccessfully() {
assumeTrue(neo4j.isNeo4j44OrEarlier());
try (Session session = neo4j.driver().session()) {
ClientException e = assertThrows(ClientException.class, () -> session.run("RETURN 10 / 0"));
ClientException e = assertThrows(ClientException.class, () -> session.run("not query"));

assertThat(e.getMessage(), containsString("/ by zero"));
assertThat(e.getMessage(), containsString("not query"));
}
}

Expand Down Expand Up @@ -712,9 +712,9 @@ void shouldThrowRunFailureImmediatelyAfterMultipleSuccessfulRunsAndCloseSuccessf
try (Session session = neo4j.driver().session()) {
session.run("CREATE ()");
session.run("CREATE ()");
ClientException e = assertThrows(ClientException.class, () -> session.run("RETURN 10 / 0"));
ClientException e = assertThrows(ClientException.class, () -> session.run("not query"));

assertThat(e.getMessage(), containsString("/ by zero"));
assertThat(e.getMessage(), containsString("not query"));
}
}

Expand All @@ -724,8 +724,8 @@ void shouldThrowRunFailureImmediatelyAndAcceptSubsequentRun() {
try (Session session = neo4j.driver().session()) {
session.run("CREATE ()");
session.run("CREATE ()");
ClientException e = assertThrows(ClientException.class, () -> session.run("RETURN 10 / 0"));
assertThat(e.getMessage(), containsString("/ by zero"));
ClientException e = assertThrows(ClientException.class, () -> session.run("not query"));
assertThat(e.getMessage(), containsString("not query"));
session.run("CREATE ()");
}
}
Expand All @@ -737,8 +737,8 @@ void shouldCloseCleanlyWhenRunErrorConsumed() {
session.run("CREATE ()");

ClientException e = assertThrows(
ClientException.class, () -> session.run("RETURN 10 / 0").consume());
assertThat(e.getMessage(), containsString("/ by zero"));
ClientException.class, () -> session.run("not query").consume());
assertThat(e.getMessage(), containsString("not query"));

session.run("CREATE ()");

Expand Down
6 changes: 3 additions & 3 deletions driver/src/test/java/org/neo4j/driver/integration/async/AsyncSessionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,17 +648,17 @@ public CompletionStage<String> execute(AsyncTransaction tx) {
@Test
void shouldNotPropagateRunFailureWhenClosed() {
assumeTrue(neo4j.isNeo4j44OrEarlier());
session.runAsync("RETURN 10 / 0");
session.runAsync("not query");

await(session.closeAsync());
}

@Test
void shouldPropagateRunFailureImmediately() {
assumeTrue(neo4j.isNeo4j44OrEarlier());
ClientException e = assertThrows(ClientException.class, () -> await(session.runAsync("RETURN 10 / 0")));
ClientException e = assertThrows(ClientException.class, () -> await(session.runAsync("not query")));

assertThat(e.getMessage(), containsString("/ by zero"));
assertThat(e.getMessage(), containsString("not query"));
}

@Test
Expand Down
8 changes: 4 additions & 4 deletions driver/src/test/java/org/neo4j/driver/integration/async/AsyncTransactionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ void shouldFailToCommitWhenQueriesFail() {

tx.runAsync("CREATE (:TestNode)");
tx.runAsync("CREATE (:TestNode)");
tx.runAsync("RETURN 10 / 0");
tx.runAsync("not query");
tx.runAsync("CREATE (:TestNode)");

ClientException e = assertThrows(ClientException.class, () -> await(tx.commitAsync()));
Expand All @@ -643,10 +643,10 @@ void shouldFailToCommitWhenBlockedRunFailed() {
assumeTrue(neo4j.isNeo4j44OrEarlier());
AsyncTransaction tx = await(session.beginTransactionAsync());

ClientException runException = assertThrows(ClientException.class, () -> await(tx.runAsync("RETURN 42 / 0")));
ClientException runException = assertThrows(ClientException.class, () -> await(tx.runAsync("not query")));

ClientException commitException = assertThrows(ClientException.class, () -> await(tx.commitAsync()));
assertThat(runException.getMessage(), containsString("/ by zero"));
assertThat(runException.getMessage(), containsString("not query"));
assertNoCircularReferences(commitException);
assertThat(commitException.getMessage(), containsString("Transaction can't be committed"));
}
Expand All @@ -665,7 +665,7 @@ void shouldRollbackSuccessfullyWhenBlockedRunFailed() {
assumeTrue(neo4j.isNeo4j44OrEarlier());
AsyncTransaction tx = await(session.beginTransactionAsync());

assertThrows(ClientException.class, () -> await(tx.runAsync("RETURN 42 / 0")));
assertThrows(ClientException.class, () -> await(tx.runAsync("not query")));

await(tx.rollbackAsync());
}
Expand Down