Resolve issue where pooled connections could leak if exception occurred #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| catch (Exception ex) | ||
| { | ||
| dispose(); | ||
| } | ||
| finally | ||
| { | ||
| release.accept( this ); |
There was a problem hiding this comment.
From the code, it looks like release.accept can fail with at least an IllegalStateException. Now this doesn't have a catch protecting it, what happens if/when this is thrown?
There was a problem hiding this comment.
That'll bubble up to the application layer - but this is good, if the pool rejects the connection return, that's a fatal problem that should get reported to the user. IllegalStateException happens whenever the pool state is corrupted, so this is good.
during close. - close in PooledConnection calls reset and then returns the session to the pool. However, returning the session was not in a finally clause, so reset throwing an exception would leak the connection, eventually draining the pool from available sessions.
jakewins
force-pushed
the
1.0-pool-close
branch
from
2729d5b to
05e3f59
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during close.
the pool. However, returning the session was not in a finally clause,
so reset throwing an exception would leak the connection, eventually
draining the pool from available sessions.