Update config API for TLS to match DIP. #111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be red until neo4j/neo4j#6134 makes its way through the pipeline |
| { | ||
| try | ||
| { | ||
| MessageDigest md = MessageDigest.getInstance( "SHA-1" ); |
There was a problem hiding this comment.
How about let's move to SHA-2 directly as SHA-1 could already be reverted nowadays?
This modifes the Config API to talk about encryption rather than TLS, as well as renaming the on/off and the tls auth config to EncryptionLevel and TrustStrategy, respectively.
boggle
force-pushed
the
1.0-tls-consistent
branch
from
a381db9 to
6b02567
Compare
|
needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifes the Config API to talk about encryption rather than TLS, as
well as renaming the on/off and the tls auth config to EncryptionLevel and
TrustStrategy, respectively.