Add a "slim" deployment option. #1024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the shaded version is the default version and we can't suddenly not shade by default, we need to jump through some loops. Note: A solution using a classifier was discarded as it would require two different poms (a normal one and the dependency-reduced one for the shades) and this is strongly discouraged. - The artifactId is concatened with a `deploymentType` property which is by default empty - Native image properties files are duplicated (there is no good transformer for them), one includes the fully qualified names of the original resources, the other one of the shaded ones - The shaded ones are excluded by default from the resources - `maven-shade-plugin` has been moved into a profile that is active unless `skipShade` is true - `maven-shade-plugin` will exclude the non-shaded native shims and include the shaded ones now - The slim profile will be activated when shading is deactived, setting deploymentType to `slim` For the final deployment via CI something like this will be necesssary (two steps) Deploy driver and the rest as used to: ``` mvn clean deploy ``` Deploy the slim version only ``` mvn -DskipShade -pl org.neo4j.driver:neo4j-java-driver clean deploy ```
injectives
reviewed
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the shaded version is the default version and we can't suddenly not shade by default, we need to jump through some loops.
Note: A solution using a classifier was discarded as it would require two different poms (a normal one and the dependency-reduced one for the shades) and this is strongly discouraged.
deploymentTypeproperty which is by default emptymaven-shade-pluginhas been moved into a profile that is active unlessskipShadeis truemaven-shade-pluginwill exclude the non-shaded native shims and include the shaded ones nowslimFor the final deployment via CI something like this will be necesssary (two steps)
Deploy driver and the rest as used to:
Deploy the slim version only