Bug fixes #428
Open
Bug fixes #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changes + add deprecation warning
|
|
||
|
|
||
| class Embedder(ABC): | ||
| class Embedder: |
There was a problem hiding this comment.
Do we care about things lost when we remove inheritance from ABC? less safety and early error handling?
There was a problem hiding this comment.
Well, the only other solution I can think of is to create a LLMInterfaceV2. If you prefer this option, I'm fine with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_invokeand_ainvokemethods, which would force users to implement these methods, even if they are already implementing theinvoke/ainvokemethod (ie would be a breaking change)Type of Change
Complexity
Complexity:
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):