Buffer pending results on session close #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a session is closed before consuming results of executed statements, we previously did not handle pending results and directly close the underlying connection - which contradicts with behaviour from other official drivers.
A sample code snippet demonstrating the use case is as follows;
This PR makes session to buffer all pending results into result buffers before closing the underlying connection and makes the results available should they be used. On the contrary, in case of an explicit transaction - the transaction will eventually be rolled back if neither
Commit
orRollback
is called.It is important to note that closing sessions before processing executed statement results is not a good practice and should be avoided - it may hide underlying errors which would be visible otherwise.