Properly normalize duration values #1523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharris4
reviewed
Sep 21, 2021
| @@ -30,7 +30,8 @@ | |||
| "e2e-local": "CYPRESS_E2E_TEST_ENV=\"local\" cypress run", | |||
| "e2e-local-open": "CYPRESS_E2E_TEST_ENV=\"local\" cypress open", | |||
| "format": "prettier-eslint --write 'src/**/!(*.min).{js,jsx,ts,tsx,css,json}' 'e2e_tests/**/*.{js,jsx,ts,tsx,css,json}' 'scripts/**/*.{js,jsx,ts,tsx,css,json}' 'build_scripts/**/*.{js,jsx,ts,tsx,css,json}'", | |||
| "jest": "jest --coverage", | |||
There was a problem hiding this comment.
This will affect CI, so we should either just add a new jest-no-cov script and leave the existing jest as it was, or else we should check what the change will mean/do on CI.
jharris4
reviewed
Sep 21, 2021
| @@ -443,9 +444,13 @@ export function mapNeo4jValuesToPlainValues(values: any): any { | |||
| */ | |||
| function neo4jValueToPlainValue(value: any) { | |||
| switch (get(value, 'constructor')) { | |||
| case neo4j.types.Duration: | |||
There was a problem hiding this comment.
Can we move this code that converts the value to a duration string to a shared util function or something?
jharris4
approved these changes
Sep 21, 2021
OskarDamkjaer
changed the title
OskarDamkjaer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Before:
After:
Preview @ https://format_duration.surge.sh