Prevent crash on database connection lost #1463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarDamkjaer
changed the title
jharris4
reviewed
Jul 8, 2021
jharris4
reviewed
Jul 8, 2021
| ) | ||
| } | ||
| exec(action: any, put: any, store: any) { | ||
| bolt |
There was a problem hiding this comment.
just in case, we should return the promise, so that the code using these can await them if necessary...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the database was shut off,
bolt.hasMultiDbSupportwill throw which we don't handle properly. This PR catches whenever it could throw.Our the metadata check running every 20 seconds is supposed to detect when a database connection is lost but it doesn't work properly (in part because of hasMultiDbSupport throwing). I spent a few hours trying to understand why/how it doesn't work, but didn't get anywhere and I think the whole file requires heavy refactoring. I ended up including a another call to
onConnectionLostas part of the metadata check instead, so that we don't retry the websocket in eternity. It's somewhat of a scope creep and not a perfect solution, so I'm happy to drop it.Preview @ http://crash_on_db_switch.surge.sh