AV2 - Misc functions #986
Merged
AV2 - Misc functions #986
+776
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-graph-data-science-client canceled.
|
FlorentinD
requested changes
Oct 21, 2025
graphdatascience/procedure_surface/api/catalog/relationships_endpoints.py
Outdated
Show resolved
Hide resolved
graphdatascience/procedure_surface/api/catalog/relationships_endpoints.py
Outdated
Show resolved
Hide resolved
graphdatascience/procedure_surface/api/catalog/relationships_endpoints.py
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| def test_defaults_set_and_list(config_endpoints: ConfigArrowEndpoints) -> None: | ||
| config_endpoints.defaults.set("test.key", 6) |
Contributor
There was a problem hiding this comment.
we should transform snake to camel case for the defaults as the python API shows the snake casing
Contributor
Author
There was a problem hiding this comment.
I will only do it for the set endpoints I think
DarthMax
force-pushed
the
av2_misc_functions
branch
from
1624c15 to
14531e1
Compare
FlorentinD
reviewed
Nov 11, 2025
Comment on lines
+23
to
+28
| config_endpoints.defaults.set("test.specific.key", "specific_value") | ||
|
|
||
| specific_defaults = config_endpoints.defaults.list(key="test.specific.key") | ||
|
|
||
| assert specific_defaults == {"test.specific.key": "specific_value"} | ||
|
|
Contributor
There was a problem hiding this comment.
NIT: you could test a snake_case field here in these tests
FlorentinD
reviewed
Nov 11, 2025
| yield job_id | ||
|
|
||
|
|
||
| @pytest.mark.skip(reason="Enable when we figure out how to retain jobs") |
Contributor
There was a problem hiding this comment.
its going against the gds_plugin container here.
you can set gds.progress_tracking_retention_period in the test container to lets say 1H to keep it.
so for the docker setting in t would be `gds_progress__tracking__retention__period
FlorentinD
approved these changes
Nov 11, 2025
Contributor
FlorentinD
left a comment
FlorentinD
left a comment
There was a problem hiding this comment.
only two smaller comments on the testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref GDSA-75