-
Notifications
You must be signed in to change notification settings - Fork 79
Images refresh batch 2 #2541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Images refresh batch 2 #2541
Conversation
…neo4j#2490) Since we moved them over from DBMS level (while still keeping the DBMS level syntax, just as another syntax for `DATABASE *`) --------- Co-authored-by: Mark Dixon <1756429+mnd999@users.noreply.github.com> Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
The Operations manual covers all releases of 2025.xx series. That's why we cannot simply replace examples with new ones, as new functionality has been added. We also need to retain examples for earlier versions of Neo4j.
On the page Database privileges, Figure 2. Syntax of GRANT and DENY database privileges is not updated. |
On the page DBMS privileges, the Figure 1. Syntax of GRANT and DENY DBMS privileges is not updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, the branch (on the right hand side) for SERVER MANAGEMENT -> SHOW SERVERS, EXECUTE Privileges, and SHOW SETTINGS privilege is unclear and might be wrong.
There are three equal groups:
- SERVER MANAGEMENT (with SHOW SERVERS at the 2nd level),
- EXECUTE PRIVILEGES (that include EXECUTE PROCEDURES, EXECUTE BOOSTED PROCEDURES, EXECUTE ADMIN(ISTRATOR) PROCEDURES, EXECUTE FUNCTIONS, and EXECUTE BOOSTED FUNCTIONS),
- and SHOW SETTINGS.
I think, we should have three equal branches for them. At the moment, their hierarchy is unclear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if to make frames of the first level blocks bold? These blocks are:
- ROLE MANAGEMENT
- USER MANAGEMENT
- IMPERSONATE
- SERVER MANAGEMENT
- DATABASE MANAGEMENT
- ALIAS MANAGEMENT
- PRIVILEGE MANAGEMENT
- EXECUTE PRIVILEGES (I think they could be grouped together)
- SHOW SETTINGS
@@ -76,7 +76,7 @@ For more details on the differences between graphs, databases, and the DBMS, ref | |||
|
|||
image::privileges_grant_and_deny_syntax_dbms_privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image::privileges-grant-and-deny-syntax-dbms-privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]
@@ -480,7 +480,7 @@ GRANT [IMMUTABLE] TRANSACTION [MANAGEMENT] [( { * \| user[, ...] } )] | |||
|=== | |||
|
|||
|
|||
image::privileges_grant_and_deny_syntax_database_privileges.svg[title="Syntax of GRANT and DENY Database Privileges"] | |||
image::privileges-grant-and-deny-syntax-database-privileges.svg[title="Syntax of GRANT and DENY Database Privileges", role=popup] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what is happening here. In line 187, image::privileges_hierarchy_database.svg[title="Database privileges hierarchy"]
is used instead of the new file name with hyphens. However, the new image is rendered in the preview.
The file name is updated in the line 483, but the old image is rendered.
This PR includes documentation updates Updated pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the blocks are hard to read and the hierarchy structure is harder to see with this layout :(
(I assume this applies to more than just this one of the hierarchy pictures but I only opened this one so far)
No description provided.