[AJmycukR] Fix for apoc.import.graphml #310
Conversation
| inputFactory.setProperty(XMLInputFactory.SUPPORT_DTD, false); | ||
| inputFactory.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, false); |
There was a problem hiding this comment.
Another possible approach could be to try to reuse the same XML parser that we use for the apoc.xml procedures, not sure how feasible that would be
There was a problem hiding this comment.
I think that different XML parsers in Java have different behaviour and work well for different things. The XMLInputFactory is however used in another place IIRC.
We could have our own XMLParserFactory which returns an XMLEventReader with sensible defaults. I leave it up to you whether you'd like to explore that. However, neither do I see this procedure staying in APOC Core in the long term, nor do I anticipate many code changes in this procedure between now and 2025 when 4.4 goes out of support.
There was a problem hiding this comment.
Ok I will not put effort into further changes then
No description provided.