Skip to content

[NOID] Fix the missing constraint error message for apoc.import.json() #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

AzuObs
Copy link
Contributor

@AzuObs AzuObs commented Jan 25, 2023

@johnlinp I've recreated this pull request because:

  • it couldn't run in the CI if it's from a fork repository
  • the commit contains a "[NOID]" tag which means it doesn't correspond to any work items from our internal Kanban tool

Apologies for the above, I think we could explain this better to the open source community. However, you should still get the credit from the commit and in the next month's release Changelog - so I hope this is OK with you. But if there are any issues please let me know, and I can encourage you to open a new PR yourself.

Fixes #290

Signed-off-by: John Lin <johnlinp@gmail.com>
@neo4j neo4j deleted a comment from CLAassistant Jan 25, 2023
@AzuObs
Copy link
Contributor Author

AzuObs commented Jan 25, 2023

This user has been manually added to the CLA repository by me.

@AzuObs AzuObs self-assigned this Jan 25, 2023
@neo4j neo4j deleted a comment from CLAassistant Jan 25, 2023
@AzuObs AzuObs merged commit 5ecd6f7 into dev Jan 25, 2023
@AzuObs AzuObs deleted the json-import-constraint branch January 25, 2023 14:04
@AzuObs
Copy link
Contributor Author

AzuObs commented Jan 25, 2023

Thank you so much for your contribution 🙇 It should go live in the next release on ~3rd of February.

@johnlinp
Copy link
Contributor

Thank you @AzuObs. It looks great to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants