Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update role selector menu + more robust user updates #854

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Update role selector menu + more robust user updates #854

merged 4 commits into from
Apr 18, 2024

Conversation

AleSim94
Copy link
Collaborator

This feature update does 2 things:

  1. Makes role selector scrollable
  2. Makes user update more robust to handle < tokens, @ etc in their name

@AleSim94 AleSim94 requested a review from alfredorubin96 April 10, 2024 07:12
@AleSim94 AleSim94 self-assigned this Apr 10, 2024
@AleSim94 AleSim94 changed the title Feature/rbac feature updates Update role selector menu + more robust user updates Apr 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

alfredorubin96
alfredorubin96 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@alfredorubin96 alfredorubin96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just shrinked the menu height so that there isn't too much white space, now it shows 5 entries

@mariusconjeaud mariusconjeaud merged commit 85f4e4f into develop Apr 18, 2024
2 checks passed
@mariusconjeaud mariusconjeaud deleted the feature/rbac_feature_updates branch April 18, 2024 10:18
@mariusconjeaud mariusconjeaud mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfredorubin96 alfredorubin96 alfredorubin96 approved these changes

Assignees

@AleSim94 AleSim94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AleSim94 @alfredorubin96 @mariusconjeaud