Fix race condition caused by incorrect date casted from serialized dashboard format

src/dashboard/DashboardThunks.ts

@@ -9,6 +9,7 @@
 import { applicationGetConnectionUser, applicationIsStandalone } from '../application/ApplicationSelectors';
 import { applicationGetLoggingSettings } from '../application/logging/LoggingSelectors';
 import { NEODASH_VERSION, VERSION_TO_MIGRATE } from './DashboardReducer';
+import { Date as Neo4jDate } from 'neo4j-driver-core/lib/temporal-types.js';
 
 export const removePageThunk = (number) => (dispatch: any, getState: any) => {
   try {
@@ -101,6 +102,16 @@
       throw `Invalid dashboard version: ${dashboard.version}. Try restarting the application, or retrieve your cached dashboard using a debug report.`;
     }
 
+    // Cast dashboard parameters from serialized format to correct types
+    Object.keys(dashboard.settings.parameters).forEach((key) => {
+      const value = dashboard.settings.parameters[key];
+
+      // Serialized Date to Neo4jDate
+      if (value && value.year && value.month && value.day) {
+        dashboard.settings.parameters[key] = new Neo4jDate(value.year, value.month, value.day);
+      }
+    });
+
     // Reverse engineer the minimal set of fields from the selection loaded.
     dashboard.pages.forEach((p) => {
       p.reports.forEach((r) => {
@@ -133,29 +144,29 @@
 
 export const saveDashboardToNeo4jThunk =
   (driver, database, dashboard, date, user, onSuccess) => (dispatch: any, getState: any) => {
     const state = getState();
     const loggingSettings = applicationGetLoggingSettings(state);
     const loguser = applicationGetConnectionUser(state);
     const neodashMode = applicationIsStandalone(state) ? 'Standalone' : 'Editor';
 
     try {
       let { uuid } = dashboard;
 
       // Dashboards pre-2.3.4 may not always have a UUID. If this is the case, generate one just before we save.
       if (!dashboard.uuid) {
         uuid = createUUID();
         dashboard.uuid = uuid;
         dispatch(setDashboardUuid(uuid));
         createUUID();
       }
 
       const { title, version } = dashboard;
 
       // Generate a cypher query to save the dashboard.
       const query =
         'MERGE (n:_Neodash_Dashboard {uuid: $uuid }) SET n.title = $title, n.version = $version, n.user = $user, n.content = $content, n.date = datetime($date) RETURN $uuid as uuid';
 
       const parameters = {
         uuid: uuid,
         title: title,
         version: version,
@@ -163,19 +174,19 @@
         content: JSON.stringify(dashboard, null, 2),
         date: date,
       };
       runCypherQuery(
         driver,
         database,
         query,
         parameters,
         1,
         () => {},
         (records) => {
           if (records && records[0] && records[0]._fields && records[0]._fields[0] && records[0]._fields[0] == uuid) {
             dispatch(createNotificationThunk('🎉 Success!', 'Your current dashboard was saved to Neo4j.'));
             onSuccess(uuid);
             if (loggingSettings.loggingMode > '1') {
               dispatch(
                 createLogThunk(
                   driver,
                   loggingSettings.loggingDatabase,
@@ -191,15 +202,15 @@
                 )
               );
             }
           } else {
             dispatch(
               createNotificationThunk(
                 'Unable to save dashboard',
                 `Do you have write access to the '${database}' database?`
               )
             );
             if (loggingSettings.loggingMode > '1') {
               dispatch(
                 createLogThunk(
                   driver,
                   loggingSettings.loggingDatabase,
@@ -219,9 +230,9 @@
         }
       );
     } catch (e) {
       dispatch(createNotificationThunk('Unable to save dashboard to Neo4j', e));
       if (loggingSettings.loggingMode > '1') {
         dispatch(
           createLogThunk(
             driver,
             loggingSettings.loggingDatabase,
@@ -274,9 +285,9 @@
 };
 
 export const loadDashboardFromNeo4jThunk = (driver, database, uuid, callback) => (dispatch: any, getState: any) => {
   const state = getState();
   const loggingSettings = applicationGetLoggingSettings(state);
   const loguser = applicationGetConnectionUser(state);
   const neodashMode = applicationIsStandalone(state) ? 'Standalone' : 'Editor';
 
   try {
@@ -306,7 +317,7 @@
             )
           );
           if (loggingSettings.loggingMode > '1') {
             dispatch(
               createLogThunk(
                 driver,
                 loggingSettings.loggingDatabase,
@@ -325,8 +336,8 @@
         } else {
           callback(records[0]._fields[0]);
           if (loggingSettings.loggingMode > '1') {
             const dashboard = JSON.parse(records[0]._fields[0]);
             dispatch(
               createLogThunk(
                 driver,
                 loggingSettings.loggingDatabase,
@@ -348,7 +359,7 @@
   } catch (e) {
     dispatch(createNotificationThunk('Unable to load dashboard to Neo4j', e));
     if (loggingSettings.loggingMode > '1') {
       dispatch(
         createLogThunk(
           driver,
           loggingSettings.loggingDatabase,
@@ -366,22 +377,22 @@
 
 export const loadDashboardFromNeo4jByNameThunk =
   (driver, database, name, callback) => (dispatch: any, getState: any) => {
     const loggingState = getState();
     const loggingSettings = applicationGetLoggingSettings(loggingState);
     const loguser = applicationGetConnectionUser(loggingState);
     const neodashMode = applicationIsStandalone(loggingState) ? 'Standalone' : 'Editor';
     try {
       const query =
         'MATCH (d:_Neodash_Dashboard) WHERE d.title = $name RETURN d.content as dashboard ORDER by d.date DESC LIMIT 1';
       runCypherQuery(
         driver,
         database,
         query,
         { name: name },
         1,
         (status) => {
           if (status == QueryStatus.NO_DATA) {
             dispatch(
               createNotificationThunk(
                 'Unable to load dashboard.',
                 'A dashboard with the provided name could not be found.'
@@ -389,16 +400,16 @@
             );
           }
         },
         (records) => {
           if (records.length == 0) {
             dispatch(
               createNotificationThunk(
                 'Unable to load dashboard.',
                 'A dashboard with the provided name could not be found.'
               )
             );
             if (loggingSettings.loggingMode > '1') {
               dispatch(
                 createLogThunk(
                   driver,
                   loggingSettings.loggingDatabase,
@@ -414,13 +425,13 @@
                 )
               );
             }
             return;
           }
 
           if (records[0].error) {
             dispatch(createNotificationThunk('Unable to load dashboard.', records[0].error));
             if (loggingSettings.loggingMode > '1') {
               dispatch(
                 createLogThunk(
                   driver,
                   loggingSettings.loggingDatabase,
@@ -436,11 +447,11 @@
                 )
               );
             }
             return;
           }
 
           if (loggingSettings.loggingMode > '1') {
             dispatch(
               createLogThunk(
                 driver,
                 loggingSettings.loggingDatabase,
@@ -456,27 +467,27 @@
               )
             );
           }
           callback(records[0]._fields[0]);
         }
       );
     } catch (e) {
       dispatch(createNotificationThunk('Unable to load dashboard from Neo4j', e));
     }
   };
 
 export const loadDashboardListFromNeo4jThunk = (driver, database, callback) => (dispatch: any) => {
   function setStatus(status) {
     if (status == QueryStatus.NO_DATA) {
       runCallback([]);
     }
   }
   function runCallback(records) {
     if (!records || !records[0] || !records[0]._fields) {
       callback([]);
       return;
     }
     const result = records.map((r, index) => {
       return {
         uuid: r._fields[0],
         title: r._fields[1],
         date: r._fields[2],
@@ -485,7 +496,7 @@
         index: index,
       };
     });
     callback(result);
   }
   try {
     runCypherQuery(
@@ -494,8 +505,8 @@
       'MATCH (n:_Neodash_Dashboard) RETURN n.uuid as uuid, n.title as title, toString(n.date) as date,  n.user as author, n.version as version ORDER BY date DESC',
       {},
       1000,
       (status) => setStatus(status),
       (records) => runCallback(records)
     );
   } catch (e) {
     dispatch(createNotificationThunk('Unable to load dashboard list from Neo4j', e));