Refactor uncontrolled component code smells #711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I'm taking a software quality course, and as a final assignment, we were instructed to perform code smell refactorings in open source projects. For this issue, I identified the Uncontrolled Component smell in 1 component.
The Uncontrolled Component smell occurs when a form doesn't use a state or prop, leading the form handling to the DOM itself. Sometimes this mean using a "ref" to access the input value instead of a state.
Code quality metrics were collected with Understand, before and after refactoring, and for this code smell, the cyclomatic, cyclomatic sum, number of functions and count line metrics were affected:
This pull request contains my refactoring for this smell.