Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved contrast for light and dark theme interfaces #566

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

nielsdejong
Copy link
Collaborator

@nielsdejong nielsdejong commented Aug 15, 2023

While testing out 2.3.2, found some places where we can improve contract between lines/borders/background to make the UI a bit nicer.

Also did some Needle styling fixes on the actions / rule-based styling modals.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 57.89% and project coverage change: +0.03% 🎉

Comparison is base (e12e49c) 47.00% compared to head (9994e7a) 47.03%.
Report is 9 commits behind head on develop.

❗ Current head 9994e7a differs from pull request most recent head 58dd726. Consider uploading reports for the commit 58dd726 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #566      +/-   ##
===========================================
+ Coverage    47.00%   47.03%   +0.03%     
===========================================
  Files          176      176              
  Lines         6857     6861       +4     
  Branches      2107     2107              
===========================================
+ Hits          3223     3227       +4     
  Misses        3593     3593              
  Partials        41       41              
Files Changed Coverage Δ
src/chart/Utils.ts 10.00% <ø> (ø)
src/chart/pie/PieChart.tsx 86.07% <ø> (ø)
src/chart/table/TableChart.tsx 63.00% <ø> (ø)
src/component/editor/CodeViewerComponent.tsx 100.00% <ø> (ø)
src/dashboard/header/DashboardHeader.tsx 75.00% <ø> (ø)
...ncedcharts/chart/choropleth/ChoroplethMapChart.tsx 2.43% <ø> (ø)
...tensions/advancedcharts/chart/radar/RadarChart.tsx 1.72% <ø> (ø)
...nsions/advancedcharts/chart/sankey/SankeyChart.tsx 76.76% <ø> (ø)
src/report/Report.tsx 59.84% <ø> (ø)
src/chart/parameter/ParameterSelectionChart.tsx 71.42% <42.85%> (+2.67%) ⬆️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…editing. Make extensions a seperate FAB. Improved styling for rule-based styling creation modal
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BennuFire BennuFire merged commit 423f486 into develop Aug 18, 2023
@nielsdejong nielsdejong mentioned this pull request Aug 21, 2023
@BennuFire BennuFire mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants