Skip to content

Schema render #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025
Merged

Schema render #1235

merged 5 commits into from
Apr 17, 2025

Conversation

prakriti-solankey
Copy link
Collaborator

image

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A PR to update the schema rendering logic and improve the graph schema extraction process. Key changes include:

  • Adding new utility functions (extractGraphSchemaFromRawData and generateGraphFromNodeAndRelVals) for processing raw graph data.
  • Updating components (SchemaViz and GraphViewModal) to use the new schema extraction functions and introducing the view property.
  • Removing obsolete code and unused variables in SchemaDropdown and GraphViewModal.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
frontend/src/utils/Utils.ts Added functions for extracting and generating graph schema from raw data.
frontend/src/types.ts Extended SchemaViewModalProps with an optional view property.
frontend/src/components/Graph/SchemaViz.tsx Updated logic to conditionally call new schema extraction based on the view prop.
frontend/src/components/Graph/SchemaDropdown.tsx Removed unused variables for a cleaner context usage.
frontend/src/components/Graph/GraphViewModal.tsx Refactored schema extraction and removed obsolete API calls.
Comments suppressed due to low confidence (1)

frontend/src/components/Graph/GraphViewModal.tsx:69

  • [nitpick] The state setter 'setViewcheck' has an inconsistent naming style compared to the variable 'viewCheck'. Consider renaming it to 'setViewCheck' for clarity and consistency.
const [viewCheck, setViewcheck] = useState<string>('enhancement');

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ishaanpatel-ip
Copy link

@prakriti-solankey Hi, Ishaan here! I am currently working at EY on a project involving Neo4j. I have hit a roadblock and could really use some guidance. Can we connect for a quick conversation?

@prakriti-solankey
Copy link
Collaborator Author

@prakriti-solankey Hi, Ishaan here! I am currently working at EY on a project involving Neo4j. I have hit a roadblock and could really use some guidance. Can we connect for a quick conversation?

Sure please tell me .

@kartikpersistent kartikpersistent merged commit 04bd47b into dev Apr 17, 2025
3 checks passed
@kartikpersistent kartikpersistent deleted the schema-render branch April 17, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants