Provide stable fallback for maybe_uninit_write_slice #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1ck
approved these changes
Oct 25, 2022
| } | ||
|
|
||
| // Checks if some code can be compiled with the current toolchain | ||
| fn compile_probe(probe: &str) -> Option<ExitStatus> { |
crates/builder/build.rs
Outdated
| fn main() { | ||
| match compile_probe(MAYBE_UNINIT_WRITE_SLICE_PROBE) { | ||
| Some(status) if status.success() => {} | ||
| _ => println!("cargo:rustc-cfg=no_maybe_uninit_write_slice"), |
There was a problem hiding this comment.
Maybe for readability, we can do
fn enable_compat_for_feature(feature_name: &str) {
println!("cargo:rust-cfg=no_{feature_name}");
}
and in the Err case:
_ => enable_compat_for_feature("maybe_uninit_write_slice")
knutwalker
force-pushed
the
reduce-features
branch
from
8efa06c to
1fd5ce9
Compare
|
@s1ck thanks, 🏓 |
Co-Authored-By: Martin Junghanns <nerdfaktor42@mailbox.org>
Co-Authored-By: Martin Junghanns <nerdfaktor42@mailbox.org>
knutwalker
force-pushed
the
reduce-features
branch
from
1fd5ce9 to
f8a6303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This acts also as a scaffold for how to maybe get rid of other feature requirements.
The idea is that we can probe if we need to fallback, which is not the case for nightly or when that features has been stabilized.
If we need to fallback, we provide a compat impl using current stable code.