Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fast-float with fast-float2 #131

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

babichjacob
Copy link
Contributor

to close #130

@babichjacob
Copy link
Contributor Author

babichjacob commented Dec 4, 2024

Some tests were already failing before I made this change:

test input::edgelist::tests::edge_list_from_linux_file ... FAILED
test input::edgelist::tests::edge_list_from_windows_file ... FAILED
test input::edgelist::tests::edge_list_with_values_from_file ... FAILED

failures:

---- input::edgelist::tests::edge_list_from_linux_file stdout ----
thread '<unnamed>' panicked at crates\builder\src\input\edgelist.rs:221:43:
range end index 27 out of range for slice of length 26
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'input::edgelist::tests::edge_list_from_linux_file' panicked at crates\builder\src\input\edgelist.rs:204:9:
a scoped thread panicked

---- input::edgelist::tests::edge_list_from_windows_file stdout ----
"C:\\Users\\Jacob\\Repositories\\graph\\crates\\builder\\resources\\windows.el"
thread '<unnamed>' panicked at crates\builder\src\input\edgelist.rs:221:43:
range end index 30 out of range for slice of length 29
thread 'input::edgelist::tests::edge_list_from_windows_file' panicked at crates\builder\src\input\edgelist.rs:204:9:       
a scoped thread panicked

---- input::edgelist::tests::edge_list_with_values_from_file stdout ----
thread '<unnamed>' panicked at crates\builder\src\input\edgelist.rs:221:43:
range end index 28 out of range for slice of length 27
thread 'input::edgelist::tests::edge_list_with_values_from_file' panicked at crates\builder\src\input\edgelist.rs:204:9:   
a scoped thread panicked
ERROR tests/graph_edgelist_test.py::test_load_graph - pyo3_runtime.PanicException: a scoped thread panicked
ERROR tests/graph_edgelist_test.py::test_load_undirected_graph - pyo3_runtime.PanicException: a scoped thread panicked     
ERROR tests/graph_test.py::test_load_graph - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize     
ERROR tests/graph_test.py::test_to_undirected - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize  
ERROR tests/graph_test.py::test_reorder - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize        
ERROR tests/numpy_neighbors_test.py::test_out_neighbors - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize
ERROR tests/numpy_neighbors_test.py::test_in_neighbors - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize
ERROR tests/numpy_neighbors_test.py::test_neighbors - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize
ERROR tests/numpy_neighbors_test.py::test_neighbors_keep_alive - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize
ERROR tests/page_rank_test.py::test_page_rank - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize  
ERROR tests/page_rank_test.py::test_pr_max_iterations - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize
ERROR tests/page_rank_test.py::test_pr_tolerance - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize
ERROR tests/page_rank_test.py::test_pr_damping_factor - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize
ERROR tests/page_rank_test.py::test_config_must_be_kwargs - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize
ERROR tests/triangle_count_test.py::test_triangle_count - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize
ERROR tests/wcc_test.py::test_wcc - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize
ERROR tests/wcc_test.py::test_config_must_be_kwargs - pyo3_runtime.PanicException: assertion failed: idx <= <u32>::MAX as usize

However, no more started failing after it.

Copy link
Collaborator

@knutwalker knutwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good to know

@knutwalker knutwalker merged commit 4a4de1b into neo4j-labs:main Dec 19, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0379 affects this crate
2 participants