Skip to content

Fixes the issue that an update removes the custom ID field on the node #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fixes the issue that an update removes the custom ID field on the node #96

merged 1 commit into from
Jul 22, 2020

Conversation

Andy2003
Copy link
Collaborator

We forgot to pass the id, when updating a node. This causes the id to be unset.
This PR resolves #95

@Andy2003 Andy2003 requested a review from jexp July 22, 2020 11:39
@jexp jexp merged commit 4792d3f into neo4j-graphql:master Jul 22, 2020
@al-jeyapal
Copy link

al-jeyapal commented Jul 22, 2020 •
edited
Loading

@jexp any chance we can get a version 1.0.1 published with this fix?

@Andy2003 Andy2003 deleted the bugfix/GH-95-keep-id-on-update branch August 3, 2020 12:45
@Andy2003 Andy2003 mentioned this pull request Sep 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jexp jexp Awaiting requested review from jexp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update mutation removes custom ID field from translated Cypher
3 participants
@Andy2003 @al-jeyapal @jexp