Skip to content

Separate sorting and paging into own input type #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

Andy2003
Copy link
Collaborator

This feature is part of migrating our API to the one generated by @neo4j/graphql.
Here we move the fields for paging and sorting into a options input type, which can be passed to queries and projected relational fields

resolves #196

@Andy2003 Andy2003 added the API-Alignment Align the API with the one defined by @neo4j/graphql label Mar 28, 2021
@Andy2003 Andy2003 requested a review from jexp March 28, 2021 16:16
@Andy2003 Andy2003 force-pushed the feature/gh-196-query-options branch from d6a1e93 to b1aed79 Compare April 14, 2021 08:23
@github-actions

This comment has been minimized.

@Andy2003 Andy2003 force-pushed the feature/gh-196-query-options branch from b1aed79 to 3464e06 Compare April 15, 2021 16:37
@github-actions

This comment has been minimized.

This feature is part of migrating our API to the one generated by `@neo4j/graphql`.
Here we move the fields for paging and sorting into a options input type, which can be passed to queries and projected relational fields

resolves #196
@Andy2003 Andy2003 force-pushed the feature/gh-196-query-options branch from 3464e06 to 17d3190 Compare April 15, 2021 16:44
@github-actions

This comment has been minimized.

Copy link
Contributor

@jexp jexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot, feel free to merge.

@Andy2003 Andy2003 merged commit f2a02d5 into master Apr 26, 2021
@Andy2003 Andy2003 deleted the feature/gh-196-query-options branch April 26, 2021 06:46
@github-actions
Copy link

Unit Test Results

    4 files  ±0      4 suites  ±0   28s ⏱️ ±0s
113 tests ±0  113 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
644 runs  ±0  642 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit f2a02d5. ± Comparison against base commit f2a02d5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-Alignment Align the API with the one defined by @neo4j/graphql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate sorting and paging into own input type
2 participants