Skip to content

Improve test navigation #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Andy2003
Copy link
Collaborator

@Andy2003 Andy2003 commented Aug 27, 2020

This change adds support for:

  • nesting tests (deep hierarchy)
  • direct navigation to failed block (cypher or cypher params)
  • let augmentation-tests provides a diff on failure that can be viewed in IntelliJ

@Andy2003 Andy2003 requested a review from jexp August 27, 2020 13:26
@Andy2003 Andy2003 force-pushed the feature/improve-tests-navigation branch 3 times, most recently from bd65789 to a3473ba Compare August 28, 2020 07:37
This change adds support for:
* nesting tests (deep hierarchy)
* direct navigation to failed block (cypher or cypher params)
* let augmentation-tests provides a diff on failure that can be viewed in IntelliJ
@Andy2003 Andy2003 force-pushed the feature/improve-tests-navigation branch from a3473ba to 48f0169 Compare August 28, 2020 08:59
testSet.line = lineNr + 1
currentDepth = depth
}
line.startsWith("CAUTION:") -> ignore = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably also ignore some others like NOTE: etc.

var title: String? = null
var current: StringBuilder? = null

var codeBlocks = mutableMapOf<String, ParsedBlock>()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would still be nice to have an object for these.

}
}

companion object {
val DEBUG = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should come from an external config or system property so it can be changed externally for test runs

Copy link
Contributor

@jexp jexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot !

@jexp
Copy link
Contributor

jexp commented Aug 30, 2020

Please add the configurability of DEBUG as a separate PR.

@jexp jexp merged commit ef9279f into neo4j-graphql:master Aug 30, 2020
@Andy2003 Andy2003 deleted the feature/improve-tests-navigation branch August 31, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants