Skip to content

Fix test not adhering to Feature.OPT_RESULT_LIST_FETCH_ALL #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Fix test not adhering to Feature.OPT_RESULT_LIST_FETCH_ALL #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tests/stub/routing/test_no_routing_v4x1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,16 @@ def test_should_pull_custom_size_and_then_all_using_session_configuration(
user_agent="007")

session = driver.session("w", database=self.adb, fetch_size=2)
res = session.run("RETURN 5 as n")
if self.driver_supports_features(
types.Feature.OPT_RESULT_LIST_FETCH_ALL
):
# This script branch expects res.list to fetch all outstanding
# records in one go.
res = session.run("RETURN 5 as n")
else:
# This script branch expects res.list to fetch all outstanding
# records while respecting the configure fetch size.
res = session.run("RETURN 1 as n")
records = res.list()

session.close()
Expand Down