Check connections for closure on LDAP Auth Credential expiration #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmontz
force-pushed
the
4.3-auth-drop-connection-on-disconnect
branch
from
95f80fc to
2cd8427
Compare
robsdedude
reviewed
Apr 30, 2021
injectives
reviewed
Apr 30, 2021
robsdedude
requested changes
May 3, 2021
Contributor
robsdedude
left a comment
robsdedude
left a comment
There was a problem hiding this comment.
Generally, I like the idea. We should consider two more things:
- We need a place to document all possible capabilities. Better yet, have them all as constants in one place in the code base
- I'd prefer if testkit would ask the backend actively for the required capabilities. This way we greatly reduce the needed network throughput as the backend does not have to send the full list of capabilities for each test.
bigmontz
force-pushed
the
4.3-auth-drop-connection-on-disconnect
branch
from
a9396ab to
be35a6a
Compare
bigmontz
force-pushed
the
4.3-auth-drop-connection-on-disconnect
branch
2 times, most recently
from
9b9bf35 to
1c7c7e5
Compare
Contributor
|
This all looks ok to me. |
robsdedude
requested changes
May 4, 2021
robsdedude
reviewed
May 4, 2021
bigmontz
force-pushed
the
4.3-auth-drop-connection-on-disconnect
branch
2 times, most recently
from
7b485a7 to
6e0094a
Compare
injectives
reviewed
May 4, 2021
This change provide a way to skip one or more tests using features names to make it easier to understand why the test is being skipped, specially in the case it is testing new features by avoid the if `list of language` approach. It does not replace the skipped lists implemented for each driver testkit-backend since the skip reason could be different. The usage of the RunTest message to fetch capabilities was done to keep a simple and backwards compatible way to use the fetch this information.
bigmontz
force-pushed
the
4.3-auth-drop-connection-on-disconnect
branch
2 times, most recently
from
ced4922 to
b86fb42
Compare
injectives
reviewed
May 5, 2021
bigmontz
force-pushed
the
4.3-auth-drop-connection-on-disconnect
branch
from
b86fb42 to
16fd55c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.